Improve error message for partitioning by nested field in Iceberg #15142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
added
the
no-release-notes
|
CI hit #14441 |
homar
approved these changes
Nov 22, 2022
findinpath
reviewed
Nov 22, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Show resolved
Hide resolved
alexjo2144
approved these changes
Nov 22, 2022
ebyhr
force-pushed
the
ebi/iceberg-nested-error-message
branch
from
f30f7b7 to
34282e2
Compare
ebyhr
changed the title
ebyhr
force-pushed
the
ebi/iceberg-nested-error-message
branch
2 times, most recently
from
44a4455 to
7976e06
Compare
|
@alexjo2144 It seems the connector couldn't read such tables. I added another commit to fix this issue and updated more code to handle other statements. Could you take another look when you have time? |
findinpath
reviewed
Nov 24, 2022
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergUtil.java
Outdated
Show resolved
Hide resolved
...roduct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergSparkCompatibility.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/iceberg-nested-error-message
branch
2 times, most recently
from
6f5806d to
8eb0b95
Compare
findinpath
approved these changes
Nov 25, 2022
alexjo2144
reviewed
Nov 28, 2022
There was a problem hiding this comment.
Should we wait for a comment on if this should be supported from the Iceberg folks before merging the first commit? #15109 (comment)
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergPageSinkProvider.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/iceberg-nested-error-message
branch
from
8eb0b95 to
771a9ee
Compare
ebyhr
changed the title
electrum
reviewed
Nov 30, 2022
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/iceberg-nested-error-message
branch
from
771a9ee to
ee4f31e
Compare
electrum
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15091