Fix predicate pushdown for identity projections #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this fixes #1114 |
martint
reviewed
Sep 13, 2019
| @@ -366,10 +366,10 @@ public void testPredicatePushDownOverProjection() | |||
|
|
|||
| // Identities should be pushed down | |||
| assertPlan( | |||
| "WITH t AS (SELECT orderkey x FROM orders) " + | |||
| "SELECT * FROM t WHERE x >1", | |||
| "WITH t AS (SELECT orderkey x, (orderkey + 1) x2 FROM orders) " + | |||
There was a problem hiding this comment.
Add a separate test case instead of overloading this one with an extra column.
martint
approved these changes
Sep 13, 2019
sopel39
force-pushed
the
ks/fix_pushdown_identities
branch
from
cb3dfa8 to
d482666
Compare
This was referenced Sep 25, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.