Attempt to upload heap dump if tests failed #15181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 758c02e. It does not correctly handle failures and fixing it would require too much overhead to keep it in a composite action.
nineinchnick
force-pushed
the
heap-dumps2
branch
from
9298cf2 to
df43ba3
Compare
what's the key diff? |
|
Here I revert adding a separate action for uploading test results and reports. It turned out to require too much overhead and didn't remove enough duplication. Uploading heap dumps is exactly the same. |
hashhar
reviewed
Nov 24, 2022
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to upload heap dump if tests failed, but only when there are no secrets defined, and running on a pull request from a repository different than
trinodb/trino.This is supposed to help debug OOM errors that happen in the CI.
Was partially discussed in #14865
Previous attempt: #15129
Additional context and related issues
n/a
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: