Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODO comment from testDropAndAddColumnWithSameName in Hive #15296

Merged
merged 1 commit into from
Dec 5, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4886,12 +4886,11 @@ public void testDropColumn()
@Override
public void testDropAndAddColumnWithSameName()
{
// TODO https://github.com/trinodb/trino/issues/15233 Hive connector can access old data after dropping and adding a column with same name
ebyhr marked this conversation as resolved.
Show resolved Hide resolved
// Override because Hive connector can access old data after dropping and adding a column with same name
assertThatThrownBy(super::testDropAndAddColumnWithSameName)
.hasMessageContaining("""
Actual rows (up to 100 of 1 extra rows shown, 1 rows in total):
[1, 2]""");
throw new SkipException("TODO");
}

@Test
Expand Down