-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark testUnionDistinctViews as @Flaky
#15297
Merged
findepi
merged 2 commits into
trinodb:master
from
findepi:findepi/retry-data-setup-when-testing-hive-views-0271ce
Dec 6, 2022
Merged
Mark testUnionDistinctViews as @Flaky
#15297
findepi
merged 2 commits into
trinodb:master
from
findepi:findepi/retry-data-setup-when-testing-hive-views-0271ce
Dec 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
test
no-release-notes
This pull request does not require release notes entry
labels
Dec 5, 2022
losipiuk
approved these changes
Dec 5, 2022
Should alleviate failure like this 2022-12-05 19:03:57 INFO: Test io.trino.tests.product.hive.TestHiveViews.testUnionDistinctViews took 38.65s 2022-12-05 19:03:57 INFO: FAILURE / io.trino.tests.product.hive.TestHiveViews.testUnionDistinctViews (Groups: hive_views) took 39.2 seconds 2022-12-05 19:03:57 SEVERE: Failure cause: io.trino.tempto.query.QueryExecutionException: java.sql.SQLException: Error while processing statement: FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.mr.MapRedTask. Error caching map.xml: java.nio.channels.ClosedByInterruptException at io.trino.tempto.query.JdbcQueryExecutor.execute(JdbcQueryExecutor.java:119) at io.trino.tempto.query.JdbcQueryExecutor.executeQuery(JdbcQueryExecutor.java:84) at io.trino.tests.product.hive.AbstractTestHiveViews.assertViewQuery(AbstractTestHiveViews.java:729) at io.trino.tests.product.hive.AbstractTestHiveViews.testUnionDistinctViews(AbstractTestHiveViews.java:571) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104) at org.testng.internal.Invoker.invokeMethod(Invoker.java:645) at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851) at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177) at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129) at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:833) Caused by: java.sql.SQLException: Error while processing statement: FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.mr.MapRedTask. Error caching map.xml: java.nio.channels.ClosedByInterruptException at org.apache.hive.jdbc.HiveStatement.execute(HiveStatement.java:275) at io.trino.tempto.query.JdbcQueryExecutor.executeQueryNoParams(JdbcQueryExecutor.java:128) at io.trino.tempto.query.JdbcQueryExecutor.execute(JdbcQueryExecutor.java:112) ... 16 more Suppressed: java.lang.Exception: Query: SELECT r_regionkey FROM UNION_DISTINCT_view at io.trino.tempto.query.JdbcQueryExecutor.executeQueryNoParams(JdbcQueryExecutor.java:136) ... 17 more Also, opportunistically mark testUnionAllViews as well.
findepi
force-pushed
the
findepi/retry-data-setup-when-testing-hive-views-0271ce
branch
from
December 5, 2022 18:45
8fd6919
to
a7ea30b
Compare
findepi
changed the title
Retry data setup when testing Hive views
Mark testUnionDistinctViews as Dec 5, 2022
@Flaky
ebyhr
approved these changes
Dec 5, 2022
findepi
deleted the
findepi/retry-data-setup-when-testing-hive-views-0271ce
branch
December 6, 2022 11:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should alleviate failure like this
Also, opportunistically mark testUnionAllViews as well.