Avoid operator lookup in Range.span #15300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be assumed that `Range` construction is more expensive than construction of a parameterized lambda, because range constructor needs to lookup the comparison operator.
findepi
added
performance
no-release-notes
losipiuk
reviewed
Dec 5, 2022
losipiuk
approved these changes
Dec 5, 2022
Remove convenience constructor that takes no `comparisonOperator` and looks it up, preventing future code from using it accidentally, where an operator is known.
`Range` is final, so `protected` access has little sense. The method is shared between `Range` and `SortedRangeSet`.
findepi
force-pushed
the
findepi/avoid-operator-lookup-in-range-span-7d3e73
branch
from
4ee6470 to
9c7b3c6
Compare
raunaqmorarka
approved these changes
Dec 5, 2022
findepi
deleted the
findepi/avoid-operator-lookup-in-range-span-7d3e73
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #15281, #10239, #15268