Inline configuration property value #15344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
approved these changes
Dec 8, 2022
Comment on lines
118
to
121
| throw new IllegalArgumentException(format("could not create spill path %s; adjust spiller-spill-path config property or filesystem permissions", path), e); | ||
| } | ||
| if (!isAccessible(path)) { | ||
| throw new IllegalArgumentException(format("spill path %s is not accessible, it must be +rwx; adjust %s config property or filesystem permissions", path, SPILLER_SPILL_PATH)); | ||
| throw new IllegalArgumentException(format("spill path %s is not accessible, it must be +rwx; adjust spiller-spill-path config property or filesystem permissions", path)); |
There was a problem hiding this comment.
Using SPILLER_SPILL_PATH constant in error messages looks fine to me. When we rename the property, we may forget to update here.
Praveen2112
force-pushed
the
config/cleanup
branch
from
3ca9ac1 to
f673230
Compare
Praveen2112
force-pushed
the
config/cleanup
branch
from
f673230 to
f24ac99
Compare
hashhar
approved these changes
Dec 9, 2022
findepi
reviewed
Dec 9, 2022
| @@ -251,7 +250,7 @@ public List<Path> getSpillerSpillPaths() | |||
| return spillerSpillPaths; | |||
| } | |||
|
|
|||
| @Config(SPILLER_SPILL_PATH) | |||
| @Config("spiller-spill-path") | |||
There was a problem hiding this comment.
the SPILLER_SPILL_PATH is still defined and still being used. revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: