Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert table handle builders in hive and iceberg #15363

Merged
merged 2 commits into from
Dec 10, 2022

Conversation

raunaqmorarka
Copy link
Member

@raunaqmorarka raunaqmorarka commented Dec 10, 2022

Description

Revert #15217

Reverted to avoid risk of bugs in the future if somebody added a field to those
classes but neglected to think about whether the field should be copied or updated
in different call sites of the new builder.

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@raunaqmorarka raunaqmorarka merged commit 4a43f9b into trinodb:master Dec 10, 2022
@raunaqmorarka raunaqmorarka deleted the revert-th branch December 10, 2022 15:15
@github-actions github-actions bot added this to the 404 milestone Dec 10, 2022
@findepi
Copy link
Member

findepi commented Dec 10, 2022

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants