Add CatalogVersion and move CatalogHandle to SPI #15425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichwang
reviewed
Dec 16, 2022
core/trino-spi/src/main/java/io/trino/spi/connector/CatalogHandle.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/CatalogHandle.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/CoordinatorDynamicCatalogManager.java
Outdated
Show resolved
Hide resolved
| } | ||
| finally { | ||
| catalogsUpdateLock.unlock(); | ||
| } | ||
| } | ||
|
|
||
| static CatalogVersion computeCatalogVersion(String catalogName, String connectorName, Map<String, String> properties) |
There was a problem hiding this comment.
Didn't we say something about catalog versions being lexical sortable? Hashing doesn't seem to satisfy that. If it's not a real constraint, maybe just remove the comment about it being lexical sortable since that would be an implementation detail from the connector side.
There was a problem hiding this comment.
In the future work, a version can be anything the catalog store want and isn't required to be sortable.
core/trino-main/src/main/java/io/trino/connector/CoordinatorDynamicCatalogManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/CoordinatorDynamicCatalogManager.java
Outdated
Show resolved
Hide resolved
electrum
approved these changes
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add CatalogVersion and move CatalogHandle to SPI
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: