Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set deterministic as false in MongoDB ObjectId function #15426

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Dec 16, 2022

Description

Set deterministic as false in MongoDB ObjectId function because
the function may return different results in a query.

Release notes

(x) Release notes are required, with the following suggested text:

# MongoDB
* Fix potential incorrect results when `objectid` function is used more than once. ({issue}`15426`)

This function may return different results in a query.
@cla-bot cla-bot bot added the cla-signed label Dec 16, 2022
@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Dec 16, 2022
@findepi
Copy link
Member

findepi commented Dec 18, 2022

(x) This is not user-visible or docs only and no release notes are required.

isn't this fixing correctness issues?

Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be testable with query-based assertions

@ebyhr
Copy link
Member Author

ebyhr commented Dec 19, 2022

This might be testable with query-based assertions

I will take a look in follow-up.

@ebyhr ebyhr merged commit 1a41f07 into trinodb:master Dec 19, 2022
@ebyhr ebyhr deleted the ebi/mongodb-objectid-deterministic branch December 19, 2022 11:27
@ebyhr ebyhr mentioned this pull request Dec 19, 2022
@github-actions github-actions bot added this to the 404 milestone Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

3 participants