Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make concurrency group in CI less specific #15455

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

nineinchnick
Copy link
Member

Description

Since 93f4cfc (#12817) the concurrency group also handles repository dispatch events, but it incorrectly includes the SHA, making it too specific. SHA should only be used for events other than pull requests or repository dispatch.

Additional context and related issues

n/a

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Dec 18, 2022
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % a question which may or may not be useful.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@hashhar
Copy link
Member

hashhar commented Dec 19, 2022

Oh, btw it is easier to see what exactly changed if the reformatting is it's own commit. 😄

@nineinchnick nineinchnick force-pushed the concurrency-group-defaults branch from d7c86d0 to c1b5983 Compare December 19, 2022 10:12
Since 93f4cfc the concurrency group also
handles repository dispatch events, but it incorrectly includes the SHA,
making it too specific. SHA should only be used for events other than
pull requests or repository dispatch.
@nineinchnick nineinchnick force-pushed the concurrency-group-defaults branch from c1b5983 to 10767ae Compare December 19, 2022 10:13
@hashhar hashhar merged commit 40dbb4f into trinodb:master Dec 19, 2022
@hashhar hashhar added the no-release-notes This pull request does not require release notes entry label Dec 19, 2022
@github-actions github-actions bot added this to the 404 milestone Dec 19, 2022
@nineinchnick nineinchnick deleted the concurrency-group-defaults branch May 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

2 participants