Add test for DROP TABLE IF EXISTS statement with non-existing object #15464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krvikash
added
the
no-release-notes
findinpath
approved these changes
Dec 19, 2022
findepi
reviewed
Dec 19, 2022
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
|
@krvikash there was a force push to the master branch (per #15365 (comment)), so your PR appears as if containing some unrelated commits. |
ebyhr
reviewed
Dec 20, 2022
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
add-tests-for-drop-table-if-exists-statement
branch
4 times, most recently
from
bb31cd2 to
d10fd45
Compare
ebyhr
approved these changes
Dec 21, 2022
core/trino-main/src/test/java/io/trino/execution/TestDropTableTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/execution/TestDropTableTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/execution/TestDropTableTask.java
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
add-tests-for-drop-table-if-exists-statement
branch
from
d10fd45 to
470843c
Compare
|
CI hit #15367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add test for DROP TABLE IF EXISTS statement with non-existing object
Additional context and related issues
NA
Release notes
(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: