Add config property to disable new Redshift type mappings #15513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
approved these changes
Dec 23, 2022
ebyhr
reviewed
Dec 23, 2022
|
I ran them and they passed |
skrzypo987
reviewed
Dec 27, 2022
| @@ -237,9 +238,11 @@ public RedshiftClient( | |||
| JdbcStatisticsConfig statisticsConfig, | |||
| QueryBuilder queryBuilder, | |||
| IdentifierMapping identifierMapping, | |||
| RemoteQueryModifier queryModifier) | |||
| RemoteQueryModifier queryModifier, | |||
There was a problem hiding this comment.
nit: queryModifier is always the last arg in *Client classes
| @@ -467,6 +470,11 @@ protected void verifyColumnName(DatabaseMetaData databaseMetadata, String column | |||
| @Override | |||
| public Optional<ColumnMapping> toColumnMapping(ConnectorSession session, Connection connection, JdbcTypeHandle type) | |||
| { | |||
| // todo remove this when legacy type mapping is no longer supported | |||
ssheikin
reviewed
Dec 28, 2022
| return legacyTypeMapping; | ||
| } | ||
|
|
||
| @Config("redshift.use-legacy-type-mapping") |
There was a problem hiding this comment.
use -> force
It has been used even before. Even more, it's used in other connectors, but as a fallback. Here it overrides improved mapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(X) Release notes are required, with the following suggested text: