Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Hive test verify method #15531

Conversation

djsstarburst
Copy link
Member

Before this commit, TestHiveTransactionalTable.verifySelectForTrinoAndHive accepted separate string arguments for the SELECT portion of the query and the WHERE clause. In practice this convention was confusing.

This commit removes the extra argument to verifySelectForTrinoAndHive specifying the WHERE clause, updating the SELECT strings to include the WHERE clause.

Description

Additional context and related issues

Release notes

(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Before this commit, TestHiveTransactionalTable.verifySelectForTrinoAndHive
accepted separate string arguments for the SELECT portion of the
query and the WHERE clause.  In practice this convention was confusing.

This commit removes the extra argument to verifySelectForTrinoAndHive
specifying the WHERE clause, updating the SELECT strings to include the
WHERE clause.
@ebyhr ebyhr merged commit 4858a0a into trinodb:master Dec 28, 2022
@github-actions github-actions bot added this to the 404 milestone Dec 28, 2022
@djsstarburst djsstarburst deleted the david.stryker/hive-test-remove-where-handling branch December 28, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants