Account for memory usage of parquet column readers #15554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
requested review from
skrzypo987,
lukasz-stec and
sopel39
and removed request for
skrzypo987
lukasz-stec
reviewed
Jan 2, 2023
lib/trino-parquet/src/test/java/io/trino/parquet/reader/TestParquetReaderMemoryUsage.java
Outdated
Show resolved
Hide resolved
sopel39
reviewed
Jan 3, 2023
lib/trino-parquet/src/test/java/io/trino/parquet/reader/flat/TestFlatColumnReader.java
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/reader/flat/FlatColumnReader.java
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/reader/decoders/ValueDecoders.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/reader/flat/FlatColumnReader.java
Show resolved
Hide resolved
sopel39
reviewed
Jan 3, 2023
lib/trino-parquet/src/main/java/io/trino/parquet/reader/ParquetReader.java
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/reader/decoders/ValueDecoders.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/reader/flat/FlatColumnReader.java
Show resolved
Hide resolved
Added accounting of memory usage to batched column readers. This takes into account the dictionary retained for decoding dictionary data pages and the extra memory usage of decompressed values from data pages.
sopel39
approved these changes
Jan 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added accounting of memory usage to batched column readers.
This takes into account the dictionary retained for decoding
dictionary data pages and the extra memory usage of decompressed
values from data pages.
Additional context and related issues
Fixes #10061
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: