Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mongo connector Atlas integration #15652

Closed
wants to merge 2 commits into from

Conversation

findepi
Copy link
Member

@findepi findepi commented Jan 10, 2023

Reverts #14988, reopens #1398

@findepi
Copy link
Member Author

findepi commented Jan 10, 2023

@ebyhr @mayankvadariya do you want to propose RN for this?

Copy link
Contributor

@huberty89 huberty89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather provide quick fix (add config a property to disable my change) than just revert it. I will start working on it.
cc @kokosing

@ebyhr
Copy link
Member

ebyhr commented Jan 13, 2023

How about

Revert specifying `authorizedDatabasesOnly` and `authorizedCollections` options in MongoDB commands due to issue with Atlas integration.

@findepi
Copy link
Member Author

findepi commented Jan 13, 2023

Thanks for release notes @ebyhr

@huberty89 are you still working on a potentially better fix?

@huberty89
Copy link
Contributor

@findepi Yes, I'm looking at possible solution for that

@findepi
Copy link
Member Author

findepi commented Jan 16, 2023

Since we broke Atlas integration in 405 and we didn't want that, let me mark this PR as a release blocker cc @trinodb/maintainers . I very much hope we merge @huberty89 's better fix, instead of this one, so treat this just as a placeholder.

@findepi findepi marked this pull request as draft January 16, 2023 11:15
@ebyhr
Copy link
Member

ebyhr commented Jan 18, 2023

FYI: The issue might not be specific to Atlas according to https://www.mongodb.com/docs/manual/release-notes/5.0-compatibility/#certain-commands-only-accept-recognized-parameters

Compatibility Changes in MongoDB 5.0
The following 5.0 changes can affect compatibility with older versions of MongoDB.

Certain Commands Only Accept Recognized Parameters
Starting in MongoDB 5.0, certain database commands raise an error if passed a parameter not explicitly accepted by the command. In MongoDB 4.4 and earlier, unrecognized parameters are silently ignored.

@findepi findepi closed this Jan 24, 2023
@findepi findepi deleted the findepi/atlas branch January 24, 2023 10:41
@Praveen2112
Copy link
Member

https://www.mongodb.com/docs/manual/release-notes/5.0-compatibility/#certain-commands-only-accept-recognized-parameters

But in case of listingDatabase - authorizedDatabases is a recognized parameter right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants