Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error-prone to 2.18.0 #15654

Closed
wants to merge 1 commit into from

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jan 10, 2023

New version actually finds some pre-existing issues with the code which are fixed along with the update itself

NO RELEASE NOTES

@wendigo
Copy link
Contributor Author

wendigo commented Jan 10, 2023

Only interesting fixes are dropping RNN on Multimap.get. According to the Javadoc, this method returns an empty collection instead of a null, so RNN is noop: core/trino-main/src/main/java/io/trino/execution/scheduler/StageTaskSourceFactory.java

@ksobolew
Copy link
Contributor

Oh, they released a new version already?

Also, my #14597 is attempting to get merged since 2.16.0 ;)

@ssheikin
Copy link
Contributor

So should this one be closed in favour of #14597 ?

@wendigo wendigo closed this Jan 12, 2023
@wendigo wendigo deleted the serafin/update-errorprone branch January 12, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants