Fix MySQL connection issue when server misconfigured #15670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unsupported type case is handled at the end of the method, since 2471b68 commit.
findepi
commented
Jan 11, 2023
| connectionProperties.setProperty("connectionTimeZone", "SERVER"); | ||
| // Try to make MySQL timestamps work (See "Solution 2a" at https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-time-instants.html and around) | ||
| // without relying on server time zone (which may be configured to be totally unusable). | ||
| // See also TODO (https://github.com/trinodb/trino/issues/15668) rethink how timestamps are mapped |
findepi
added
the
no-release-notes
anusudarsan
approved these changes
Jan 11, 2023
hashhar
approved these changes
Jan 11, 2023
| // See "Solution 2a" at https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-time-instants.html - these properties are required to preserve point-in-time when operating with MySQL TIMESTAMP types | ||
| connectionProperties.setProperty("preserveInstants", "true"); | ||
| connectionProperties.setProperty("connectionTimeZone", "SERVER"); | ||
| // Try to make MySQL timestamps work (See "Solution 2a" at https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-time-instants.html and around) |
There was a problem hiding this comment.
Suggested change
| // Try to make MySQL timestamps work (See "Solution 2a" at https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-time-instants.html and around) | |
| // Try to make MySQL timestamps work (See https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-time-instants.html) |
|
A TODO to test with server in non-UTC zone should also be added to the same place probably. |
i am aware, just wanted to make it easier to locate piece of text on that page |
When MySQL server has `server_time_zone` set to e.g. `Coordinated Universal Time`, the connection couldn't be made. Use UTC instead of relying on the server system time zone.
findepi
force-pushed
the
findepi/fix-mysql-connection-issue-when-server-misconfigured-8196a5
branch
from
728e741 to
70009be
Compare
added |
findepi
deleted the
findepi/fix-mysql-connection-issue-when-server-misconfigured-8196a5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When MySQL server has
server_time_zoneset to e.g.Coordinated Universal Time, the connection couldn't be made. Use UTC instead ofrelying on the server system time zone.