Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reading float as double in ORC and Parquet for Iceberg type change #15681

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Support reading float as double in ORC and Parquet for Iceberg type change #15681

merged 1 commit into from
Jan 16, 2023

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Jan 12, 2023 •
edited
Loading

Description

Fixes #15650

Release notes

(x) Release notes are required, with the following suggested text:

# Iceberg
* Fix failure when reading columns whose type was changed from `float` to `double` by other query engines. ({issue}`15650`)

@cla-bot cla-bot bot added the cla-signed label Jan 12, 2023
@ebyhr ebyhr self-assigned this Jan 12, 2023
@ebyhr ebyhr force-pushed the ebi/iceberg-orc-real-double branch 2 times, most recently from 90583a0 to 0f8a058 Compare January 12, 2023 23:46
@ebyhr ebyhr changed the title Support reading ORC float as double for Iceberg type evolution Support reading float as double in ORC and Parquet for Iceberg type change Jan 12, 2023
@ebyhr ebyhr requested review from dain and findepi January 13, 2023 02:17
@ebyhr ebyhr force-pushed the ebi/iceberg-orc-real-double branch from b1ca097 to d1e2733 Compare January 13, 2023 05:52
@ebyhr ebyhr force-pushed the ebi/iceberg-orc-real-double branch from d1e2733 to 3a3481b Compare January 13, 2023 12:20
@ebyhr ebyhr merged commit 3efdb05 into trinodb:master Jan 16, 2023
@ebyhr ebyhr deleted the ebi/iceberg-orc-real-double branch January 16, 2023 02:32
@ebyhr ebyhr mentioned this pull request Jan 16, 2023
Closed
@github-actions github-actions bot added this to the 406 milestone Jan 16, 2023
@raunaqmorarka raunaqmorarka mentioned this pull request Jan 16, 2023
Merged
@colebow colebow mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praveen2112 Praveen2112 Praveen2112 left review comments

@alexjo2144 alexjo2144 alexjo2144 approved these changes

@findepi findepi findepi approved these changes

@dain dain Awaiting requested review from dain

Assignees

@ebyhr ebyhr

Labels
cla-signed
Milestone
406
Development

Successfully merging this pull request may close these issues.

Iceberg connector can't read columns after Spark changed float type to double type in ORC and Parquet
4 participants
@ebyhr @findepi @alexjo2144 @Praveen2112