Support rescaled decimals in optimized parquet reader #15713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
force-pushed
the
pqr-decimal-types
branch
3 times, most recently
from
8139396 to
1e15859
Compare
raunaqmorarka
force-pushed
the
pqr-decimal-types
branch
3 times, most recently
from
493cfc5 to
2811faf
Compare
Allows using the optimized plain encoding decoder for BINARY. Added testing for BINARY backed decimals in AbstractTestParquetReader
Co-authored-by: Raunaq Morarka <raunaqmorarka@gmail.com>
raunaqmorarka
force-pushed
the
pqr-decimal-types
branch
from
2811faf to
952fd7e
Compare
sopel39
approved these changes
Jan 20, 2023
lib/trino-parquet/src/main/java/io/trino/parquet/reader/ColumnReaderFactory.java
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/reader/ColumnReaderFactory.java
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/reader/ColumnReaderFactory.java
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/ParquetReaderUtils.java
Show resolved
Hide resolved
Co-authored-by: Krzysztof Skrzypczynski <krzysztof.skrzypczynski@starburstdata.com>
Co-authored-by: Raunaq Morarka <raunaqmorarka@gmail.com>
Co-authored-by: Raunaq Morarka <raunaqmorarka@gmail.com>
Co-authored-by: Krzysztof Skrzypczynski <krzysztof.skrzypczynski@starburstdata.com>
RLE, BIT_PACKED are used only for definition/repetition levels, dictionary ids and boolean values
Since all the necessary types are expected to be supported now, we will fallback to old column readers for flat column types only when the optimized reader is explicitly disabled. This ensures that any cases not supported by the optimized reader are not hidden while also keeping the old reader available as a fallback behind the optimized parquet reader flag.
raunaqmorarka
force-pushed
the
pqr-decimal-types
branch
from
952fd7e to
bcdd8a0
Compare
skrzypo987
approved these changes
Jan 20, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support rescaled decimals in optimized parquet reader
Additional context and related issues
This completes the support for flat column types in optimized parquet reader
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: