Fix precision loss when coercing TIME to TIME TZ and fix abundant precision when coercing DATE to TIMESTAMP TZ #15862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
requested review from
electrum,
martint,
losipiuk,
raunaqmorarka and
ebyhr
losipiuk
approved these changes
Jan 26, 2023
martint
approved these changes
Jan 26, 2023
|
CI #12535 |
findepi
changed the title
findepi
force-pushed
the
findepi/fix-precision-loss-when-coercing-time-to-time-tz-70acd5
branch
from
6f45e63 to
1b4b7b4
Compare
martint
approved these changes
Jan 26, 2023
ebyhr
approved these changes
Jan 26, 2023
Previously `date` would coerce to `timestamp(3) with time zone`, now it gets coerced to `timestamp(0) with time zone`.
findepi
force-pushed
the
findepi/fix-precision-loss-when-coercing-time-to-time-tz-70acd5
branch
from
1b4b7b4 to
b66b0c9
Compare
findepi
deleted the
findepi/fix-precision-loss-when-coercing-time-to-time-tz-70acd5
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15861
Fixes #15865