Support register_table and unregister_table procedures in Iceberg JDBC catalog
#15874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/iceberg-jdbc-unregister-table
branch
from
2fca4f1 to
6436ac9
Compare
findinpath
reviewed
Feb 14, 2023
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/jdbc/TrinoJdbcCatalog.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/iceberg-jdbc-unregister-table
branch
from
6436ac9 to
6664d0e
Compare
findinpath
reviewed
Feb 14, 2023
| @@ -60,6 +73,14 @@ protected QueryRunner createQueryRunner() | |||
| warehouseLocation = Files.createTempDirectory("test_iceberg_jdbc_catalog_smoke_test").toFile(); | |||
| closeAfterClass(() -> deleteRecursively(warehouseLocation.toPath(), ALLOW_INSECURE)); | |||
| TestingIcebergJdbcServer server = closeAfterClass(new TestingIcebergJdbcServer()); | |||
| jdbcCatalog = (JdbcCatalog) buildIcebergCatalog("tpch", ImmutableMap.<String, String>builder() | |||
| .put(CATALOG_IMPL, JdbcCatalog.class.getName()) | |||
There was a problem hiding this comment.
nit: I'd rather avoid using static imports for these properties. Their names are rather generic and this can turn out to be error prone in the maintenance.
There was a problem hiding this comment.
CATALOG_IMPL comes from CatalogProperties class. I don't feel qualified access improves anything.
findinpath
approved these changes
Feb 14, 2023
phd3
approved these changes
Feb 14, 2023
| @@ -186,13 +190,15 @@ public Transaction newCreateTableTransaction(ConnectorSession session, SchemaTab | |||
| @Override | |||
| public void registerTable(ConnectorSession session, SchemaTableName tableName, String tableLocation, String metadataLocation) | |||
| { | |||
| throw new TrinoException(NOT_SUPPORTED, "registerTable is not supported for Iceberg JDBC catalogs"); | |||
| jdbcClient.createTable(tableName.getSchemaName(), tableName.getTableName(), metadataLocation); | |||
There was a problem hiding this comment.
should we add the reason behind not using the jdbc catalogs' register table (seems like Cannot invoke "org.apache.iceberg.util.SerializableSupplier.get()" because "this.hadoopConf" is null) so that someone doesn't try to "optimize" this by removing jdbcClient object that's being used for this specific purpose? Or when the underlying code gets fixed - we can update this.
alexjo2144
approved these changes
Feb 14, 2023
krvikash
approved these changes
Feb 14, 2023
ebyhr
force-pushed
the
ebi/iceberg-jdbc-unregister-table
branch
from
6664d0e to
6d00587
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support
register_tableandunregister_tableprocedures in Iceberg JDBC catalogFixes #15853
Release notes
(x) Release notes are required, with the following suggested text: