Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @FileExists validation #15940

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

findinpath
Copy link
Contributor

Description

Fail-fast in case that the file referenced in the configuration does not exist.

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@findinpath findinpath added the no-release-notes This pull request does not require release notes entry label Feb 2, 2023
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix TestS3SecurityMappingConfig too?

@findinpath findinpath force-pushed the findinpath/config-file-exists branch from e0372bb to ad29843 Compare February 3, 2023 06:43
@findinpath
Copy link
Contributor Author

CI hit #12535

@ebyhr ebyhr merged commit f41df6b into trinodb:master Feb 3, 2023
@github-actions github-actions bot added this to the 407 milestone Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

4 participants