Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading parquet column with unused dictionary #15942

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Fix reading parquet column with unused dictionary #15942

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b69c787
Remove unnecessary ColumnChunkDescriptor class
raunaqmorarka Feb 2, 2023
a68b2b4
Convert DataPage into a sealed class
raunaqmorarka Feb 2, 2023
31b14d9
Fix reading parquet column with unused dictionary
raunaqmorarka Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/trino-parquet/src/main/java/io/trino/parquet/DataPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@

import java.util.OptionalLong;

public abstract class DataPage
public abstract sealed class DataPage
raunaqmorarka marked this conversation as resolved.
Show resolved Hide resolved
extends Page
permits DataPageV1, DataPageV2
{
protected final int valueCount;
private final OptionalLong firstRowIndex;
Expand Down
2 changes: 1 addition & 1 deletion lib/trino-parquet/src/main/java/io/trino/parquet/DataPageV1.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import static com.google.common.base.MoreObjects.toStringHelper;
import static java.util.Objects.requireNonNull;

public class DataPageV1
public final class DataPageV1
extends DataPage
{
private final Slice slice;
Expand Down
2 changes: 1 addition & 1 deletion lib/trino-parquet/src/main/java/io/trino/parquet/DataPageV2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import static com.google.common.base.MoreObjects.toStringHelper;
import static java.util.Objects.requireNonNull;

public class DataPageV2
public final class DataPageV2
extends DataPage
{
private final int rowCount;
Expand Down