Fix null projects handling in RowPositionsAppender #15948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of null projection with UnknownType, Rle with null ByteArrayBlock value is created. This breaks RowPositionsAppender assumption about incoming block type.
lukasz-stec
force-pushed
the
ls/064-row-appender-null-project
branch
from
669608d to
dd4e339
Compare
sopel39
approved these changes
Feb 3, 2023
| @@ -100,20 +110,29 @@ public void append(IntArrayList positions, Block block) | |||
| public void appendRle(Block value, int rlePositionCount) | |||
| { | |||
| ensureCapacity(rlePositionCount); | |||
| AbstractRowBlock sourceRowBlock = (AbstractRowBlock) value; | |||
| if (sourceRowBlock.isNull(0)) { | |||
| if (value instanceof AbstractRowBlock sourceRowBlock) { | |||
There was a problem hiding this comment.
nit: I think there might be other places where we assume AbstractRowBlock always
sopel39
reviewed
Feb 3, 2023
| @@ -270,6 +273,7 @@ public void testRowWithNestedFields() | |||
| public static Object[][] types() | |||
| { | |||
| return Arrays.stream(TestType.values()) | |||
| .filter(testType -> !testType.equals(TestType.UNKNOWN)) | |||
There was a problem hiding this comment.
UnknownType does not support values other than null and tests are producing non null blocks based on the type provided
|
CI hit: #15429 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case of null projection with UnknownType,
Rle with null ByteArrayBlock value is created.
This breaks RowPositionsAppender assumption
about incoming block type.
Additional context and related issues
Release notes
( X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: