Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config props for adaptive remote task req size #15951

Merged

Conversation

blvckcoffee
Copy link
Member

Description

  • Adds documentation for adaptive remote task request size to Query management properties

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 2, 2023
@blvckcoffee blvckcoffee requested a review from colebow February 2, 2023 17:25
@github-actions github-actions bot added the docs label Feb 2, 2023
@blvckcoffee blvckcoffee force-pushed the jj/update-query-mgmt-properties branch from dd45e13 to afdaae1 Compare February 2, 2023 21:42
@blvckcoffee
Copy link
Member Author

Thanks for the initial feedback. I have made changes according to your recommendations. @mosabua @colebow

@mosabua
Copy link
Member

mosabua commented Feb 6, 2023

We discussed this with @electrum and also looked at the code some more. @blvckcoffee is updating accordingly and then we will work with @arosa on user facing explanation.

@blvckcoffee blvckcoffee force-pushed the jj/update-query-mgmt-properties branch from afdaae1 to 77f59fa Compare February 8, 2023 03:12
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mosabua mosabua requested a review from arhimondr February 23, 2023 17:13
@mosabua
Copy link
Member

mosabua commented Feb 23, 2023

@arhimondr can you merge this please?

@arhimondr arhimondr merged commit df94598 into trinodb:master Feb 23, 2023
@github-actions github-actions bot added this to the 408 milestone Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants