-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config props for adaptive remote task req size #15951
Merged
arhimondr
merged 1 commit into
trinodb:master
from
blvckcoffee:jj/update-query-mgmt-properties
Feb 23, 2023
Merged
Add config props for adaptive remote task req size #15951
arhimondr
merged 1 commit into
trinodb:master
from
blvckcoffee:jj/update-query-mgmt-properties
Feb 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
requested changes
Feb 2, 2023
colebow
reviewed
Feb 2, 2023
blvckcoffee
force-pushed
the
jj/update-query-mgmt-properties
branch
from
February 2, 2023 21:42
dd45e13
to
afdaae1
Compare
jhlodin
approved these changes
Feb 6, 2023
We discussed this with @electrum and also looked at the code some more. @blvckcoffee is updating accordingly and then we will work with @arosa on user facing explanation. |
blvckcoffee
force-pushed
the
jj/update-query-mgmt-properties
branch
from
February 8, 2023 03:12
afdaae1
to
77f59fa
Compare
mosabua
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@arhimondr can you merge this please? |
arhimondr
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: