Enhance TrinoFileSystem#deleteFiles with files failure count #16006
Conversation
| @@ -1231,12 +1236,13 @@ private void executeExpireSnapshots(ConnectorSession session, IcebergTableExecut | |||
| long expireTimestampMillis = session.getStart().toEpochMilli() - retention.toMillis(); | |||
| TrinoFileSystem fileSystem = fileSystemFactory.create(session); | |||
| List<String> pathsToDelete = new ArrayList<>(); | |||
| AtomicLong failedToDelete = new AtomicLong(); | |||
There was a problem hiding this comment.
This doesn't have to be thread safe, if that delete function was called from multi thread it probably wouldn't work as pathsToDelete is not thread safe.
… to int Return number of files that failed to delete.
Return number of files that failed to delete.
krvikash
force-pushed
the
enhance-batch-delete-with-failure-count
branch
from
afb1f78 to
a8e21e0
Compare
|
This still requires answer to #15981 (comment) question
|
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Apart from throwing runtime exception with message @findepi should we close this PR? |
Description
I am proposing to enhance TrinoFileSystem#deleteFiles to track the number of files that failed to delete.
Failure count is needed for the case when we want to throw
BulkDeletionFailureExceptionin #15981See Comments here
#15981 (comment)
#15981 (comment)
Release notes
(X) This is not user-visible or docs only and no release notes are required.