Fix MemoryMetadata#streamTableColumnNames #16062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation returned a lazy iterator over the contents of the tables map which could throw a ConcurrentModificationException if another thread modified the map before the caller fully consumed the iterator. Instead, the iterator returned must be from a fully materialized collection evaluated fully before returning from the method and releasing the object monitor.
ebyhr
approved these changes
Feb 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
MemoryMetadata#streamTableColumnNamesby returning am iterator over a fully materialized collection evaluated fully before returning from the method and releasing the object monitor. The previous implementation returned a lazy iterator over the contents of the tables map which could throw aConcurrentModificationExceptionif another thread modified the map before the caller fully consumed the iterator.Additional context and related issues
Run failure: https://github.com/trinodb/trino/actions/runs/4138831198/jobs/7158842747
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: