Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for trailing space in location in delta lake #16330

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Add tests for trailing space in location in delta lake #16330

merged 1 commit into from
Mar 3, 2023

Conversation

pajaks
Copy link
Member

@pajaks pajaks commented Mar 1, 2023

Description

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Mar 1, 2023
@pajaks pajaks marked this pull request as ready for review March 1, 2023 14:22
@pajaks
Copy link
Member Author

pajaks commented Mar 1, 2023

@ebyhr Could you run with secrets?

@findepi
Copy link
Member

findepi commented Mar 1, 2023

/test-with-secrets sha=4dc58914b7373e5a3d66f8691baade031c42a9f7

@pajaks pajaks self-assigned this Mar 1, 2023
@pajaks pajaks added the delta-lake Delta Lake connector label Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4306675973

@findinpath
Copy link
Contributor

CI hit #13199

Copy link
Contributor

@krvikash krvikash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Few comments.

@ebyhr
Copy link
Member

ebyhr commented Mar 2, 2023

/test-with-secrets sha=7a75980e67837ed68c51019cd547c259ae257b56

@ebyhr
Copy link
Member

ebyhr commented Mar 3, 2023

@ebyhr ebyhr merged commit 2fdb090 into trinodb:master Mar 3, 2023
@github-actions github-actions bot added this to the 409 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector
Development

Successfully merging this pull request may close these issues.

6 participants