-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable colocated join by default #16381
Merged
raunaqmorarka
merged 1 commit into
trinodb:master
from
radek-kondziolka:rk/enable-colocated-join-by-default
Mar 13, 2023
Merged
Enable colocated join by default #16381
raunaqmorarka
merged 1 commit into
trinodb:master
from
radek-kondziolka:rk/enable-colocated-join-by-default
Mar 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radek-kondziolka
force-pushed
the
rk/enable-colocated-join-by-default
branch
from
March 7, 2023 14:22
23a87b6
to
e4b7c17
Compare
core/trino-main/src/test/java/io/trino/sql/planner/optimizations/TestAddExchangesPlans.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/optimizations/TestAddExchangesPlans.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/optimizations/TestColocatedJoin.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/optimizations/TestColocatedJoin.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/optimizations/TestColocatedJoin.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/optimizations/TestAddExchangesPlans.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/optimizations/TestColocatedJoin.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/optimizations/TestColocatedJoin.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/optimizations/TestColocatedJoin.java
Outdated
Show resolved
Hide resolved
radek-kondziolka
force-pushed
the
rk/enable-colocated-join-by-default
branch
2 times, most recently
from
March 8, 2023 10:43
5396d2b
to
e4ee9e7
Compare
core/trino-main/src/test/java/io/trino/sql/planner/optimizations/TestColocatedJoin.java
Outdated
Show resolved
Hide resolved
radek-kondziolka
force-pushed
the
rk/enable-colocated-join-by-default
branch
from
March 9, 2023 11:11
e4ee9e7
to
019ff87
Compare
Some results about colocated join (enabled by default from now): Intro info:
explain analyze for: 1. When colocated-join is enabled (default one)
2. When colocated join is disabled - there is more data shuffling.
|
raunaqmorarka
approved these changes
Mar 10, 2023
arhimondr
approved these changes
Mar 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables colocated joins by default.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: