Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for TRINO_PASSWORD usage #16390

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Mar 6, 2023

Description

Specifically the usage of quotes seems necessary since we hear from users stumbling over password values with $ and other values.

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Mar 6, 2023
Copy link

@dashea dashea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion about user names, LGTM

docs/src/main/sphinx/client/cli.rst Show resolved Hide resolved
@mosabua
Copy link
Member Author

mosabua commented Mar 14, 2023

Could you check and merge please @electrum ?

@mosabua
Copy link
Member Author

mosabua commented Mar 17, 2023

Maybe @ebyhr or @hashhar could look and merge?

@mosabua
Copy link
Member Author

mosabua commented Mar 17, 2023

Btw. docs build runs fine locally.

@hashhar hashhar merged commit 3e3c143 into trinodb:master Mar 17, 2023
@github-actions github-actions bot added this to the 411 milestone Mar 17, 2023
@mosabua mosabua deleted the mm/trinopwd branch March 17, 2023 14:52
@mosabua
Copy link
Member Author

mosabua commented Mar 17, 2023

Thanks @hashhar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants