Update first_tested_version to 18 month ago in JDBC driver test
#16701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
Is this good to get merged @ebyhr ? |
wendigo
approved these changes
Apr 27, 2023
findepi
reviewed
Apr 28, 2023
| @@ -10,7 +10,7 @@ maven_run_tests="${maven} clean test ${MAVEN_TEST:--B} -pl :trino-test-jdbc-comp | |||
|
|
|||
| current_version=$(${maven} help:evaluate -Dexpression=project.version -q -DforceStdout) | |||
| previous_released_version=$((${current_version%-SNAPSHOT}-1)) | |||
| first_tested_version=352 | |||
| first_tested_version=368 | |||
There was a problem hiding this comment.
can we automate that?
eg
trino master$ git tag --contain $(git rev-list master --since='18 month ago' | tail -1) | sort | head -1
364(to be verified whether git rev-list master --since filters by author-date or commit-date; we must use the latter)
There was a problem hiding this comment.
Thanks for considering my idea!
(to be verified whether
git rev-list master --sincefilters by author-date or commit-date; we must use the latter)
i haven't verified that. Have you?
also, would this one be better?
--since-as-filter=<date>
Show all commits more recent than a specific date. This visits all commits in the range, rather than stopping at the first commit which is older than a specific date.
There was a problem hiding this comment.
The filter uses commit-date as far as I tested and confirmed git/git@9669778
ebyhr
force-pushed
the
ebi/jdbc-test-version
branch
from
b97bdfe to
0665d73
Compare
ebyhr
changed the title
first_tested_version to 368 in JDBC driver testfirst_tested_version to 18 month ago in JDBC driver test
ebyhr
force-pushed
the
ebi/jdbc-test-version
branch
from
0665d73 to
e7409fd
Compare
hashhar
approved these changes
Apr 29, 2023
wendigo
approved these changes
May 4, 2023
ebyhr
force-pushed
the
ebi/jdbc-test-version
branch
from
e7409fd to
9e466b2
Compare
wendigo
approved these changes
Jul 24, 2023
This reduces the testing target versions because it leads to timeout on CI.
ebyhr
force-pushed
the
ebi/jdbc-test-version
branch
from
9e466b2 to
600480c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
first_tested_versionto 368 in JDBC driver test to avoid CI timeout.Release notes
(x) This is not user-visible or docs only and no release notes are required.