Refactor testRenameTableToLongTableName to remove Iceberg override #16707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
test
no-release-notes
This was referenced Mar 24, 2023
kokosing
approved these changes
Mar 24, 2023
| @@ -1634,24 +1634,48 @@ private void testCreateTableLikeForFormat(IcebergFileFormat otherFormat) | |||
| // For this reason the source and the copied table will share the same directory. | |||
| format_version = 2, | ||
| location = '%s', | ||
| partitioning = ARRAY['adate'] | ||
| )""", |
Refactor `testRenameTableToLongTableName` test so that Iceberg tests do not have to override the test method.
Previously we were retrying on "Execution Error, return code 2 from org.apache.hadoop.hive.ql.exec.mr.MapRedTask". As CI shown, the return code may vary, sometimes it is e.g. 1. In the meantime we introduced broader retry patterns for Hive query failures, so let's use these.
|
CI #16277 |
findepi
force-pushed
the
findepi/refactor-testrenametabletolongtablename-to-remove-iceberg-override-750064
branch
from
27875a1 to
a4ee59f
Compare
findepi
deleted the
findepi/refactor-testrenametabletolongtablename-to-remove-iceberg-override-750064
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
testRenameTableToLongTableNametest so that Iceberg tests do not have to override the test method.Also fixes #7535 per #7535 (comment)