-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually instrument okhttp with OTEL in trino-jdbc #17101
Conversation
client/trino-jdbc/src/main/java/io/trino/jdbc/NonRegisteringTrinoDriver.java
Outdated
Show resolved
Hide resolved
We should copy the necessary attributes from Instrumenting the HTTP client inside the driver should be sufficient for context propagation. For users who want higher level integration, we should see if the Library Instrumentation for JDBC using |
7da5c04
to
7a5b19c
Compare
client/trino-client/src/main/java/io/trino/client/StatementClientFactory.java
Show resolved
Hide resolved
7a5b19c
to
02558cd
Compare
Can you rebase this PR? I'll merge it when the automation finishes |
You could also run the integration test that checks whether jdbc driver is shaded properly (i've added this test recently) |
02558cd
to
1483033
Compare
Cancelled build. The jdbc jar is not shaded properly:
|
3c749ec
to
05fcad1
Compare
Because trino-jdbc is using a shaded version of okhttp, it does not get automatically instrumented when using an OTEL Java agent.
05fcad1
to
b6a2f25
Compare
All done, tested manually. |
LGTM |
Thanks @nineinchnick ! |
Description
Because trino-jdbc is using a shaded version of okhttp, it does not get automatically instrumented when using an OTEL Java agent.
Thanks to this, both client and server traces can be correlated, with JDBC traces as the root.
This is a follow-up to #16950.
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: