Fix testFilterWithUdf

[elonazoulay]

This is due to differences in how Pinot handles IEEE-754 approximate numerics pre/post Pinot 0.12.1.

See apache/pinot#10637

Description

Additional context and related issues

Release notes

(X ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

[kokosing]

Can you please fix pinot tests to use capital letters for SQL keywords like: SELECT, FROM, WHERE? Let's do it as separate Pr.

[elonazoulay]

Sure! Will do.

[elonazoulay]

Created #17109

[kokosing]

Can you please let me know what are you fixing here? Is this a flaky issue? Do you have any github issues reported for the problem you are fixing? How the problem you are fixing manifests?

[elonazoulay]

Sure, the issue is created for Pinot: apache/pinot#10637.
Before Pinot 0.12.1 the Pinot expression FLOOR(EXP(2 * LN(3))) return 9.0 and after 0.12.1 returns 8.0 - more details in the Pinot issue.

It is not a flaky test, it is due to differences in how Pinot handles IEEE-754 approximate numerics - specific info which affected this test is in the pinot issue.

The behavior is deterministic: pre 0.12.1 and post 0.12.1 the results are the same, just different across Pinot versions.

The problem manifested with a failing TestDynamicTable::testFilterWithUdf. The test passes with Pinot 11.0 libraries. Also running 11.0 Pinot and 12.1 Pinot and issuing the query shows different results - the specific results are in the pinot issue.

lmk if you need any more info.

[hashhar]

before merging this we need to verify if the Pinot results actually depend on JVM version being used instead of the Pinot version itself.

[elonazoulay]

before merging this we need to verify if the Pinot results actually depend on JVM version being used instead of the Pinot version itself.

I tried this on java11 and java17 and they behave the same. Changing Pinot version results in the different behavior. Also updated the pinot issue with those findings.

To repro:
Run the TestDynamicTable::testFilterWithUdf pre and post the commit that upgrades trino-pinot libraries to 0.12.1 - this uses java17.

Run the "latest" and "previous" version from the base connector smoke test, do docker ps --no-trunc | grep StartController and open the query console from the port mapped to Pinot 9000 (the controller and ui port) and issue a query like this:

SELECT <column>, exp(2 * ln(3)) from <table>

[elonazoulay]

Also, adding .1 to the query in the test guarantees that the actual and expected result will be equal regardless of the version.

lmk if you need more info.

[hashhar]

Indeed, I can see the different behaviour as well. Thanks for including repro steps.

LGTM.