Use Page#getColumns in TableWriterOperator #17147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids an additional unnecessary copy of the Block[] array for each input page in TableWriter by using the Page helper method instead of constructing the block array externally (which incurs an defensive copy when passed into the Page constructor).
pettyjamesm
force-pushed
the
use-page-getcolumns-in-tablewriter
branch
from
0f2fbb6 to
329ddfa
Compare
electrum
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoids an additional unnecessary copy of the
Block[]array for each input page inTableWriterOperatorby using the Page helper method instead of constructing the block array externally (which incurs an defensive copy when passed into the Page constructor).Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: