Refactor internal http client usage #17187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/refactor-internal-http-client-usage
branch
4 times, most recently
from
222cfcf to
a9a0fef
Compare
|
@electrum PTAL. I think that I got this change right |
lukasz-walkiewicz
approved these changes
Apr 24, 2023
core/trino-main/src/main/java/io/trino/server/InternalCommunicationHttpClientModule.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/InternalCommunicationHttpClientModule.java
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/refactor-internal-http-client-usage
branch
2 times, most recently
from
cbfe88b to
a301138
Compare
|
@electrum ptal |
kokosing
reviewed
Apr 25, 2023
core/trino-main/src/main/java/io/trino/server/InternalCommunicationHttpClientModule.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/InternalCommunicationHttpClientModule.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/InternalCommunicationHttpClientModule.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/InternalCommunicationHttpClientModule.java
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/InternalCommunicationModule.java
Show resolved
Hide resolved
electrum
approved these changes
Apr 25, 2023
core/trino-main/src/main/java/io/trino/server/InternalCommunicationHttpClientModule.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/InternalCommunicationHttpClientModule.java
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/server/InternalCommunicationHttpClientModule.java
Outdated
Show resolved
Hide resolved
The previous approach was dangerous, as it was modifying configuration for all HTTP clients and adding global filters even for HTTP clients there were not supposed to be used for internal communication. With this change, it's now intentional which HTTP clients are supposed to use secured internal communication.
wendigo
force-pushed
the
serafin/refactor-internal-http-client-usage
branch
from
a301138 to
2672cc2
Compare
ssheikin
approved these changes
Apr 26, 2023
kokosing
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach was dangerous, as it was modifying configuration for all HTTP clients and adding global filters even for HTTP clients there were not supposed to be used for internal communication.
With this change, it's now intentional which HTTP clients are supposed to use secured internal communication.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: