Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document decimal type mapping in MongoDB connector #17325

Merged
merged 1 commit into from
May 9, 2023

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented May 2, 2023

Description

  • For the MongoDB connector

Additional context and related issues

Fixes #17322

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label May 2, 2023
@github-actions github-actions bot added the docs label May 2, 2023
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would include the connector name in the commit title instead of the commit body.

docs/src/main/sphinx/connector/mongodb.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/mongodb.rst Outdated Show resolved Hide resolved
@ebyhr ebyhr changed the title Add decimal type mapping info Document decimal type mapping info in MongoDB connector May 2, 2023
@mosabua mosabua changed the title Document decimal type mapping info in MongoDB connector Document decimal type mapping in MongoDB connector May 9, 2023
@mosabua mosabua merged commit 09aa9dd into trinodb:master May 9, 2023
@mosabua mosabua deleted the dec-mongodb branch May 9, 2023 23:00
@mosabua
Copy link
Member Author

mosabua commented May 9, 2023

Related question @ebyhr .. the mapping has a ObjectId data type .. but from what I know there is no such thing in Trino .. is it just a random string .. or an int or UUID or something else .. once I know I can send another PR .. just wont have time to dig in the code.

@ebyhr
Copy link
Member

ebyhr commented May 9, 2023

@github-actions github-actions bot added this to the 417 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Update documentation for type mapping in MongoDB connector
2 participants