Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve title for alter table limitation fragment #17336

Merged
merged 1 commit into from
May 4, 2023

Conversation

tlblessing
Copy link
Member

@tlblessing tlblessing commented May 3, 2023

Description

Improve header to be more specific to its content.

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label May 3, 2023
@tlblessing tlblessing requested review from jhlodin and mosabua May 3, 2023 20:10
@tlblessing tlblessing added the docs label May 3, 2023
@mosabua
Copy link
Member

mosabua commented May 3, 2023

We do not want to have separate section for each version of ALTER TABLE .. and we probably need to add more limitations or maybe even have some in place already. The current header is still correct as it stands.

@tlblessing
Copy link
Member Author

We do not want to have separate section for each version of ALTER TABLE .. and we probably need to add more limitations or maybe even have some in place already. The current header is still correct as it stands.

@mosabua this is just applicable to a few fragments (includes) in the repo. Not all permutations of ALTER TABLE. This edit makes it immediately clear as to the command flavor. Easier for readers to consume and quickly skim and comprehend the content. And this makes it consistent with the ALTER TABLE EXECUTE sections. cc: @jhlodin

@mosabua
Copy link
Member

mosabua commented May 4, 2023

Okay .. that sounds good @tlblessing .. can you please just verify that none of the usage of the fragment are followed by some other ALTER TABLE content that would make the header wrong. Once we know that for sure I can merge.

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thank you for confirming.

@mosabua mosabua merged commit 6673284 into trinodb:master May 4, 2023
@github-actions github-actions bot added this to the 417 milestone May 4, 2023
@tlblessing tlblessing deleted the tb/doc-5972 branch May 4, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants