Fix Iceberg statistics loading after snapshot expiration #17356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously getting stats would fail with NPE: ``` Caused by: java.lang.NullPointerException: Cannot invoke "org.apache.iceberg.Snapshot.parentId()" because the return value of "org.apache.iceberg.Table.snapshot(long)" is null at io.trino.plugin.iceberg.TableStatisticsReader$2.computeNext(TableStatisticsReader.java:328) at io.trino.plugin.iceberg.TableStatisticsReader$2.computeNext(TableStatisticsReader.java:322) at com.google.common.collect.AbstractSequentialIterator.next(AbstractSequentialIterator.java:74) at io.trino.plugin.iceberg.TableStatisticsReader$1.computeNext(TableStatisticsReader.java:305) at io.trino.plugin.iceberg.TableStatisticsReader$1.computeNext(TableStatisticsReader.java:284) at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:146) at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:141) at io.trino.plugin.iceberg.TableStatisticsReader.readNdvs(TableStatisticsReader.java:232) at io.trino.plugin.iceberg.TableStatisticsReader.makeTableStatistics(TableStatisticsReader.java:160) at io.trino.plugin.iceberg.TableStatisticsReader.getTableStatistics(TableStatisticsReader.java:93) at io.trino.plugin.iceberg.IcebergMetadata.lambda$getTableStatistics$77(IcebergMetadata.java:2501) at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708) at io.trino.plugin.iceberg.IcebergMetadata.getTableStatistics(IcebergMetadata.java:2481) ```
findepi
requested review from
homar,
ebyhr,
alexjo2144,
findinpath and
djsstarburst
homar
approved these changes
May 5, 2023
findinpath
reviewed
May 5, 2023
| @Test | ||
| public void testShowStatsAsOf() | ||
| { | ||
| Session writeSession = withStatsOnWrite(getSession(), false); |
There was a problem hiding this comment.
nit: extract "show_stats_as_of" to a variable.
findinpath
reviewed
May 5, 2023
| ('key', null, 4, 0, null, '1', '5'), -- NDV present, stats "inherited" from previous snapshot | ||
| (null, null, null, null, 5, null, null)"""); | ||
|
|
||
| // Re-analyzing after snapshot expired |
There was a problem hiding this comment.
Which "snapshot expired" are you referring to here?
findinpath
reviewed
May 5, 2023
| // Snapshot referenced by `previous` had no parent. | ||
| return null; | ||
| } | ||
| return verifyNotNull(snapshot.parentId(), "snapshot.parentId()"); |
There was a problem hiding this comment.
verifyNotNull seem redundant here - given that we check above
if (snapshot.parentId() == null)
There was a problem hiding this comment.
yes, obviously.
it's here for readability & future proofing that we do not return end-of-data on this line accidentally.
otherwise i could just have
return snapshot.parentId();
without preceding if on that value
findinpath
approved these changes
May 5, 2023
raunaqmorarka
approved these changes
May 5, 2023
findepi
deleted the
findepi/fix-iceberg-statistics-loading-after-snapshot-expiration-51be93
branch
|
Does this need release notes? @findepi |
|
yes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously getting stats would fail with NPE: