-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add include-coordinator to node scheduler properties docs #17366
Add include-coordinator to node scheduler properties docs #17366
Conversation
@mosabua This property didn't seem to fit under any of the subheadings within the existing file, so I added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only other question is if we should link this whole properties page from the context where the property is also mention on the deploy page
fe1a8b5
to
9ef75bb
Compare
@mosabua The Deploying Trino page has a configuration properties section that reads: The Properties reference provides a comprehensive list of the supported properties for topics such as General properties, Resource management properties, Query management properties, Web UI properties, and others. These node scheduler properties would be included in "others", but if you think they need to be mentioned explicitly, let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one question.
9ef75bb
to
954fbe1
Compare
Probably ok to leave as is then |
954fbe1
to
e1c1bf4
Compare
Description
include-coordinator
to the node scheduler properties reference documentationAdditional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: