Handle missing MV StorageDescriptor in Glue #17383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
commented
May 8, 2023
| // Not a view TODO getView should return empty | ||
| assertThatThrownBy(() -> metadata.getView(session, table)) | ||
| .isInstanceOf(TrinoException.class) | ||
| .hasMessage("View data missing prefix: /* Presto Materialized View: eyJvcmlnaW5hbFNxbCI6IlNFTEVDVCAxIiwiY29sdW1ucyI6W3sibmFtZSI6ImEiLCJ0eXBlIjoiaW50ZWdlciJ9XX0= */"); |
There was a problem hiding this comment.
Will be fixed by #17276 .
losipiuk
approved these changes
May 9, 2023
losipiuk
approved these changes
May 9, 2023
Handle case when `StorageDescriptor` is missing in a materialized view table object stored in Glue.
The `convertParameters` converts parameters from Glue model to Trino model (basically null checks). It should not be called on parameters coming from Trino model.
findepi
force-pushed
the
findepi/handle-missing-mv-storagedescriptor-in-glue-57ac88
branch
from
6f382fc to
20eb224
Compare
This follows the guards we have for accessing Table.getTableType. This obsoletes `convertParameters` method, so it got removed.
findepi
force-pushed
the
findepi/handle-missing-mv-storagedescriptor-in-glue-57ac88
branch
from
20eb224 to
caec2f6
Compare
findepi
commented
May 9, 2023
| @@ -164,7 +164,8 @@ public static boolean isTrinoMaterializedView(String tableType, Map<String, Stri | |||
| public static boolean canDecodeView(Table table) | |||
| { | |||
| // we can decode Hive or Presto view | |||
| return table.getTableType().equals(VIRTUAL_VIEW.name()); | |||
| return table.getTableType().equals(VIRTUAL_VIEW.name()) && | |||
| !isTrinoMaterializedView(table.getTableType(), table.getParameters()); | |||
There was a problem hiding this comment.
This was proposed in #15221 but back then we couldn't test it. Now we can thanks to the test added by Grant.
canDecodeView should be removed (#17276 (comment)), leaving this to a follow-up (#17276).
|
test (plugin/trino-bigquery) rate limiting test (plugin/trino-hive) #17412 test (plugin/trino-iceberg, minio-and-avro) #11140 (comment) |
findepi
deleted the
findepi/handle-missing-mv-storagedescriptor-in-glue-57ac88
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle case when
StorageDescriptoris missing in a materialized view table object stored in Glue.@grantatspothero 's #17276 with reduced scope
Fixes: #17274