Update various dependencies (both libraries and plugins) #17384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires updating google bigquery dependencies to 26.14.0
wendigo
force-pushed
the
serafin/update-plugins
branch
from
4c0150c to
ceef368
Compare
wendigo
commented
May 8, 2023
|
CI hit #11140 |
kokosing
approved these changes
May 8, 2023
| @@ -1944,7 +1944,7 @@ | |||
| <plugin> | |||
| <groupId>org.skife.maven</groupId> | |||
| <artifactId>really-executable-jar-maven-plugin</artifactId> | |||
| <version>1.0.5</version> | |||
| <version>2.1.1</version> | |||
There was a problem hiding this comment.
It looks like a major change. What changed?
There was a problem hiding this comment.
The way zip is made executable. Plugin works the same
| @@ -1105,7 +1105,7 @@ | |||
| <dependency> | |||
| <groupId>com.github.ben-manes.caffeine</groupId> | |||
| <artifactId>caffeine</artifactId> | |||
There was a problem hiding this comment.
Where this is used? Can we drop it maybe?
There was a problem hiding this comment.
It is used. We can rewrite call sites
nineinchnick
approved these changes
May 9, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring cleaning in progress :)