Use bigger data set to address testStatsBasedRepartitionData flakiness #17431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
test
no-release-notes
The source table, tpch.tiny.orders, has 15K rows.
Previously the test used `tpch.tiny.nation`. The tiny schema is sf0.01. Now will use sf0.03. Since the test requires source table to have stats, a copy of the table is created. Despite the increased data size locally the test runs faster now. This is because the test internally uses retries to cover flakiness and now it needs fewer retries to succeed (usually no retries).
findepi
force-pushed
the
findepi/use-bigger-data-set-to-address-teststatsbasedrepartitiondata-flakiness-0f249c
branch
from
9174e8c to
88eb9a1
Compare
|
Best reviewed with |
sopel39
approved these changes
May 10, 2023
findepi
deleted the
findepi/use-bigger-data-set-to-address-teststatsbasedrepartitiondata-flakiness-0f249c
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the test used
tpch.tiny.nation. The tiny schema is sf0.01. Now will use sf0.03. Since the test requires source table to have stats, a copy of the table is created.Despite the increased data size locally the test runs faster now. This is because the test internally uses retries to cover flakiness and now it needs fewer retries to succeed (usually no retries).
Fixes #11140