Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type mapping section #17573

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

Jessie212
Copy link
Contributor

@Jessie212 Jessie212 commented May 19, 2023

Description

Added type mapping section to Kinesis and Redis connector docs.

Additional context and related issues

Additional changes needed that are related to closed PRs: #14331 and #14811.

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 19, 2023
@github-actions github-actions bot added the docs label May 19, 2023
@Jessie212 Jessie212 force-pushed the jt/type-mapping-kinesis branch from a88faf7 to fea2ea0 Compare May 19, 2023 19:01
@Jessie212 Jessie212 requested review from jhlodin and hashhar May 19, 2023 19:02
@Jessie212
Copy link
Contributor Author

I closed the last PR because Kafka is not getting a new type mapping section and I didn't want to muck up the commits. I think, once this PR is approved and merged, I can apply the fragments with the protobuf format entry to Kafka.

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of a bunch of files done. Please address comments and do similar edits on the other files that I have not reviewed yet. Ping me when done.

docs/src/main/sphinx/connector/avro-decoder.fragment Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/avro-decoder.fragment Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/avro-decoder.fragment Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/avro-decoder.fragment Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/avro-decoder.fragment Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/json-decoder.fragment Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/json-decoder.fragment Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/json-decoder.fragment Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/json-decoder.fragment Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/json-decoder.fragment Outdated Show resolved Hide resolved
@mosabua
Copy link
Member

mosabua commented Jul 7, 2023

I am good with this to merge in terms of wording and such. Content all looks good as well but I have to rely on @hashhar for technical input.

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Any final objections @hashhar or @ebyhr or should I go ahead and merge.

@mosabua mosabua merged commit f858552 into trinodb:master Jul 24, 2023
@github-actions github-actions bot added this to the 423 milestone Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants