Attempt to Refactor identify mapping to use in non jdbc connector

[vlad-lyutenko]

Description

To raise discussion

Additional context and related issues

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

[kokosing]

Please rebase

[kokosing]

I would squash these commits.

[kokosing]

LGTM % comments and review from others.

[krvikash]

LGTM

[kokosing]

% nits

[kokosing]

protected or private?

[vlad-lyutenko]

cannot, PhoenixMetadata need it:

    private String toRemoteSchemaName(ConnectorSession session, String schemaName)
    {
        try (Connection connection = phoenixClient.getConnection(session)) {
            return identifierMapping.toRemoteSchemaName(phoenixClient.getRemoteIdentifiers(connection), session.getIdentity(), schemaName);
        }
        catch (SQLException e) {
            throw new TrinoException(PHOENIX_METADATA_ERROR, "Couldn't get casing for the schema name", e);
        }
    }

[kokosing]

it it is about LazyConnection, to not populate (create) connection each time.

[vlad-lyutenko]

Not sure, connection is already created when we pass it to:

public JdbcRemoteIdentifiers createJdbcRemoteIdentifies(Connection connection)
        {
            return new JdbcRemoteIdentifiers(baseJdbcClient, connection, storesUpperCaseIdentifiers(connection));
        }

we just don't want to call this :

DatabaseMetaData metadata = connection.getMetaData();
                storesUpperCaseIdentifiers = metadata.storesUpperCaseIdentifiers();

all the time when we call createJdbcRemoteIdentifies