Add support for varchar to timestamp coercion in hive tables #18014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
force-pushed
the
praveen/varchar_to_timestamp_coercion_2
branch
from
27cf204 to
9385cbc
Compare
Praveen2112
force-pushed
the
praveen/varchar_to_timestamp_coercion_2
branch
from
9385cbc to
6a087ce
Compare
Praveen2112
requested review from
findepi,
atanasenko,
raunaqmorarka,
kokosing,
krvikash,
vlad-lyutenko and
marcinsbd
Praveen2112
force-pushed
the
praveen/varchar_to_timestamp_coercion_2
branch
2 times, most recently
from
ef81e4a to
21edd63
Compare
atanasenko
approved these changes
Jul 26, 2023
plugin/trino-hive/src/test/java/io/trino/plugin/hive/coercions/TestTimestampCoercer.java
Outdated
Show resolved
Hide resolved
krvikash
reviewed
Jul 26, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/coercions/TimestampCoercer.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/coercions/TimestampCoercer.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/coercions/TestTimestampCoercer.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/coercions/TestTimestampCoercer.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/coercions/TestTimestampCoercer.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/coercions/TestTimestampCoercer.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/coercions/TestTimestampCoercer.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/coercions/TestTimestampCoercer.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/coercions/TestTimestampCoercer.java
Outdated
Show resolved
Hide resolved
marcinsbd
approved these changes
Jul 26, 2023
| LocalDateTime dateTime = LOCAL_DATE_TIME.parse(value.toStringUtf8(), LocalDateTime::from); | ||
| long epochSecond = dateTime.toEpochSecond(UTC); | ||
| if (epochSecond < START_OF_MODERN_ERA_SECONDS) { | ||
| throw new TrinoException(HIVE_INVALID_TIMESTAMP_COERCION, "Coercion on historical dates is not supported"); |
There was a problem hiding this comment.
Why we throw exception here, we are not able to adjust date using GregorianCalendar and month -1 ?
There was a problem hiding this comment.
Hive supports different way of coercing timestamp across various version (2 and 3) and various types (ORC/Parquet/RC) for some it uses java.sql.Timestamp and other it uses a different way - so we are restricting them
There was a problem hiding this comment.
So we just cannot predict what is the way of storing such date in underlying datasource (is it for example shifted for -1 month or not), so we just deny such cases.
There was a problem hiding this comment.
It is not storing but actually the way it coerces from String to Timestamp
vlad-lyutenko
approved these changes
Jul 26, 2023
- Static import of utf8Slice
Praveen2112
force-pushed
the
praveen/varchar_to_timestamp_coercion_2
branch
from
21edd63 to
ed788a8
Compare
|
@krvikash AC |
raunaqmorarka
approved these changes
Jul 26, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/coercions/TimestampCoercer.java
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/coercions/TimestampCoercer.java
Show resolved
Hide resolved
|
@raunaqmorarka Thanks for the review. AC |
Praveen2112
force-pushed
the
praveen/varchar_to_timestamp_coercion_2
branch
from
ed788a8 to
7d80d8d
Compare
Praveen2112
changed the title
Praveen2112
force-pushed
the
praveen/varchar_to_timestamp_coercion_2
branch
from
7d80d8d to
614ab46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows coerce a varchar type to timestamp in hive tables.
Additional context and related issues
Depends on #18004
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: