Support optimized local scheduling of kudu splits #18121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is red. |
hackeryang
force-pushed
the
kudu_split_local_scheduling
branch
from
b387473 to
d4873bc
Compare
I have fixed the CI error, it was because i didn't add |
Praveen2112
reviewed
Jul 7, 2023
plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduSplit.java
Outdated
Show resolved
Hide resolved
plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduClientSession.java
Outdated
Show resolved
Hide resolved
hackeryang
force-pushed
the
kudu_split_local_scheduling
branch
from
d4873bc to
9cbd3cf
Compare
Praveen2112
reviewed
Jul 14, 2023
plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduClientSession.java
Outdated
Show resolved
Hide resolved
hackeryang
force-pushed
the
kudu_split_local_scheduling
branch
from
9cbd3cf to
4cdf8b8
Compare
Praveen2112
reviewed
Jul 27, 2023
plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduClientConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduClientConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduClientConfig.java
Outdated
Show resolved
Hide resolved
hackeryang
force-pushed
the
kudu_split_local_scheduling
branch
from
4cdf8b8 to
d68a170
Compare
Praveen2112
approved these changes
Jul 27, 2023
|
Thanks for working on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now the Hive Connector supports optimized local scheduling when Trino workers are deployed on the same nodes with HDFS, but Kudu doesn't, which we can see from
KuduSplit.getAddresses():Kudu scanner clients fetch data from tablet leaders by default, so we add leaders' host addresses from
KuduScanTokenintoKuduSplitto support this.Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: