Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support check constraints for MERGE #18137

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Support check constraints for MERGE #18137

merged 3 commits into from
Aug 23, 2023

Conversation

pajaks
Copy link
Member

@pajaks pajaks commented Jul 5, 2023 •
edited by ebyhr
Loading

Description

Fixes #15411

Release notes

(x) Release notes are required, with the following suggested text:

# General & Delta Lake
* Support check constraints for `MERGE` statements. ({issue}`15411`)

@cla-bot cla-bot bot added the cla-signed label Jul 5, 2023
@pajaks pajaks requested review from ebyhr and findinpath July 5, 2023 10:32
@pajaks pajaks self-assigned this Jul 5, 2023
@findinpath
Copy link
Contributor

Support check constraints for MERGE statement in Delta

This seems to be more related to the engine.
Probably Delta Lake will be a follow-up.

@ebyhr ebyhr requested a review from martint July 5, 2023 12:19
@pajaks pajaks marked this pull request as draft July 5, 2023 13:30
@pajaks
Copy link
Member Author

pajaks commented Jul 5, 2023

Not ready for review yet (lots of failures in CI is related to this changes)

@pajaks pajaks marked this pull request as ready for review July 10, 2023 13:21
@pajaks
Copy link
Member Author

pajaks commented Jul 10, 2023 •
edited
Loading

This seems to be more related to the engine. Probably Delta Lake will be a follow-up.

Changes in Delta code are not needed to MERGE. Added product test to ensure it's working properly.

martint
martint reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@martint martint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments

core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java Outdated Show resolved Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java Show resolved Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java Outdated Show resolved Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java Outdated Show resolved Hide resolved
@ebyhr
Copy link
Member

ebyhr commented Jul 31, 2023

@martint Please take another look.

@pajaks
Copy link
Member Author

pajaks commented Aug 7, 2023

Rebased to remove conflicts

@pajaks
Support check constraints for MERGE statement in engine
5edd09a 
Changes in DeltaLake tests are included here as changes
in engine enables functionality in Delta connector implicitly
@martint martint merged commit f3c25e0 into trinodb:master Aug 23, 2023
@martint martint changed the title Support check constraints for MERGE statement in Delta Support check constraints for MERGE Aug 23, 2023
@github-actions github-actions bot added this to the 425 milestone Aug 23, 2023
@colebow colebow mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findinpath findinpath findinpath left review comments

@ebyhr ebyhr ebyhr left review comments

@martint martint martint left review comments

Assignees

@pajaks pajaks

Labels
cla-signed
Milestone
425
Development

Successfully merging this pull request may close these issues.

Add support for CHECK constraint to UPDATE and MERGE statements
4 participants
@pajaks @findinpath @ebyhr @martint