Fix TASK_SCALE_WRITERS_MAX_WRITER_COUNT in test #18276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It relates to #18005 |
kokosing
force-pushed
the
origin/master/154_fix-test
branch
from
32ad7a6 to
323f7b5
Compare
sopel39
approved these changes
Jul 13, 2023
| @@ -61,7 +63,10 @@ protected void assertJdbcConnections(@Language("SQL") String query, int expected | |||
| assertQueryFails(query, errorMessage.get()); | |||
| } | |||
| else { | |||
| getQueryRunner().execute(query); | |||
| Session querySession = Session.builder(getSession()) | |||
| .setSystemProperty(TASK_SCALE_WRITERS_MAX_WRITER_COUNT, "4") | |||
There was a problem hiding this comment.
@kokosing To disable scaling it might be better to set task_scale_writers_enabled to false.
https://trino.io/docs/current/admin/properties-writer-scaling.html#task-scale-writers-enabled
If this session property is not fixed then running this locally most likely will fail as number of writers depends on number of CPUs and so expected number of created connections will be different.
kokosing
force-pushed
the
origin/master/154_fix-test
branch
from
323f7b5 to
1844cd0
Compare
vlad-lyutenko
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TASK_SCALE_WRITERS_MAX_WRITER_COUNT in test
If this session property is not fixed then running this locally most
likely will fail as number of writers depends on number of CPUs and so
expected number of created connections will be different.